Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2-develop] Travis: surround variable TRAVIS_BRANCH with double-quotes instead of single-quotes #11704

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

Related with PR #11667.

In dev/travis/before_script.sh, surround variable TRAVIS_BRANCH with double-quotes instead of single-quotes to get interpreted correctly:
captura de pantalla 2017-10-24 a las 1 56 46

This is a little demo of what Travis may be parsing:
captura de pantalla 2017-10-24 a las 1 52 39

Description

This may affect the way static test are executed, or over which files are performed.

Fixed Issues (if relevant)

None AFAIK

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…single-quotes, to get interpreted correctly in dev/travis/before_script.sh
@okorshenko okorshenko self-assigned this Oct 24, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 24, 2017
@okorshenko okorshenko merged commit ecb071d into magento:2.2-develop Oct 24, 2017
okorshenko pushed a commit that referenced this pull request Oct 24, 2017
…S_BRANCH with double-quotes instead of single-quotes #11704
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 deleted the FR22#TRAVIS-BRANCH-SINGLE-TO-DOUBLE-QUOTES branch October 25, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants